fix: write new dataset on update table if it doesn't exist #19269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
superset-github-bot
bot
added
the
Superset-Community-Partners
eschutho
changed the title
eschutho
removed
the
Superset-Community-Partners
eschutho
force-pushed
the
elizabeth/fix-dataset-table-update
branch
from
97899f6 to
42ca7a8
Compare
|
🏷️ preset:2022.11 |
sadpandajoe
pushed a commit
to preset-io/superset
that referenced
this pull request
Mar 21, 2022
(cherry picked from commit 88029e2)
michael-hoffman-26
pushed a commit
to nielsen-oss/superset
that referenced
this pull request
Mar 23, 2022
villebro
pushed a commit
that referenced
this pull request
Apr 3, 2022
(cherry picked from commit 88029e2)
mistercrunch
added
🍒 1.5.0
🍒 1.5.1
🍒 1.5.2
🍒 1.5.3
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
We are currently dual writing any updates/additions of the SqlaTable to the new Dataset models. We found some errors during update where the new dataset should also be updated, but it doesn't exist. I'm not sure if the dataset wasn't created because when the migration to backfill was run a new SqlaTable was created and we missed it, or we're missing it somewhere else. But for now, I'm catching this error and recreating the new dataset if the shadow model wasn't created.
I'm only updating the hook where we're currently seeing errors. There's potentially more that we can do on this after more monitoring.
TESTING INSTRUCTIONS
Difficult to reproduce in order to test manually, but I recreated the situation in unit tests.
ADDITIONAL INFORMATION